Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC/FIX: clarify the docs for check_figures_equal#16940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tacaswell
Copy link
Member

PR Summary

Clarify that the names matter and add a check with a better exception.

closes#16916

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant

@tacaswelltacaswell added this to thev3.2.2 milestoneMar 27, 2020
Clarify that the names matter and add a check with a better exception.closesmatplotlib#16916
@tacaswelltacaswellforce-pushed thedoc_compare_figures_equal branch fromd2328fe tob0d63b5CompareMarch 30, 2020 03:37
@tacaswell
Copy link
MemberAuthor

@QuLogic both comments addressed.

Co-Authored-By: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Anybody can merge after CI pass.

@QuLogic
Copy link
Member

Thistest_too_many_date_ticks seems a bit painful, timing out on macOS before and now it's crashing on AppVeyor.

@tacaswell
Copy link
MemberAuthor

Opened#16973 to try and make that test more efficent.

@QuLogicQuLogic merged commitb01325c intomatplotlib:masterMar 31, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 31, 2020
QuLogic added a commit that referenced this pull requestMar 31, 2020
…940-on-v3.2.xBackport PR#16940 on branch v3.2.x (DOC/FIX: clarify the docs for check_figures_equal)
@tacaswelltacaswell deleted the doc_compare_figures_equal branchMay 6, 2021 23:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

check_figures_equal regression from 3.2.0 to 3.2.1
4 participants
@tacaswell@QuLogic@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp