Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add tests for toolmanager.#16933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:toolmanager
Apr 15, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedMar 27, 2020•
edited
Loading

... and fix Help tool for tk (it needs a gif icon, generated (like the
other gifs) withconvert -antialias -geometry 24x24 help.svg help.gif)
(#6610).

... and also edit the matplotlibrc template to mention its availability.

Edit: plenty of new coverage:https://codecov.io/gh/matplotlib/matplotlib/compare/d9b722f8a6ee91955f83609b52b2d2b203316385...11346704f6e42f85b2a19cccc6f3be6b81451bb9/tree/lib/matplotlib

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.3.0 milestoneMar 27, 2020
@anntzeranntzerforce-pushed thetoolmanager branch 2 times, most recently from5448b1f to1134670CompareMarch 27, 2020 17:39
@tacaswell
Copy link
Member

Restarted the failing CI job (sub-process timeouts on mac on travis). Anyone can merge on green.

@timhoffm
Copy link
Member

Subprocess still times out.

@anntzer
Copy link
ContributorAuthor

I wouldn't be surprised if that really failed, but that'll need someone on a Mac to test locally...

... and fix Help tool for tk (it needs a gif icon, generated (like theother gifs) with `convert -antialias -geometry 24x24 help.svg help.gif`).... and also edit the matplotlibrc template to mention its availability.
@anntzer
Copy link
ContributorAuthor

Actually toolmanager is clearly not implemented for macosx, so let's just skip it.

@QuLogicQuLogic merged commita96b83d intomatplotlib:masterApr 15, 2020
@anntzeranntzer deleted the toolmanager branchApril 15, 2020 23:40
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@tacaswell@timhoffm@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp