Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Avoid changing dpi in Text.get_window_extent if unspecified.#16927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
QuLogic wants to merge1 commit intomatplotlib:masterfromQuLogic:text-dpi

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedMar 27, 2020•
edited
Loading

PR Summary

Somehow this causes height changes to propagate from the canvas until it's zero-height (for Tk at least). This is probably a bug, but it's much more subtle and difficult to find, so this patch will suffice for now.

See#16926, which this fixes, but not entirely satisfactorily. Maybe if we're lucky, it'll fix the flakiness on AppVeyor too.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogicQuLogic added Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: text labelsMar 27, 2020
@QuLogicQuLogic added this to thev3.3.0 milestoneMar 27, 2020
Somehow this causes height changes to propagate from the canvas untilit's zero-height (for Tk at least). This is probably a bug, but it'smuch more subtle and difficult to find, so this patch will suffice fornow.
@QuLogic
Copy link
MemberAuthor

Closing in favour of#16929, which I believe to be the more correct fix.

@QuLogicQuLogic deleted the text-dpi branchMarch 27, 2020 06:40
@anntzeranntzer removed their request for reviewMarch 27, 2020 09:55
@tacaswelltacaswell removed the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelMar 30, 2020
@tacaswelltacaswell removed this from thev3.3.0 milestoneMar 30, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp