Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Test the macosx backend on Travis.#16923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:cimacos
Mar 27, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedMar 26, 2020•
edited
Loading

PR Summary

Split out of#16921.

edit: proof that it worked:https://codecov.io/gh/matplotlib/matplotlib/compare/54b426397c0e7567edaee4f7f77036c2b8569573...a90006151abc353ad26a3ef36895bf0180cd8762/src/lib/matplotlib/backends/backend_macosx.py

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.3.0 milestoneMar 26, 2020
@anntzeranntzerforce-pushed thecimacos branch 2 times, most recently from50ad39e toa900061CompareMarch 26, 2020 21:13
@anntzer
Copy link
ContributorAuthor

Let's see whether we can also get coverage for the macosx extension module...

@QuLogic
Copy link
Member

It doesn't look like macOS's compiler has what we need for coverage. I think llvm uses a different flag or a different linker to get that to work?

@QuLogic
Copy link
Member

Actually, it may be that you need to pass--coverage inLDFLAGS too (which I think should be done on all systems, actually).

@anntzer
Copy link
ContributorAuthor

Let's get this part in first, and defer the coverage to another PR; I reverted the change re: coverage.

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 when CI passes

@QuLogicQuLogic merged commitd809e01 intomatplotlib:masterMar 27, 2020
@anntzeranntzer deleted the cimacos branchMarch 27, 2020 20:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp