Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix use of psfrags in ps backend + usetex.#16913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Looks like psfrags interacts badly with `\newgeometry`, so we need touse `\geometry` instead in the custom preamble to set the paper size.In turn this means that `\usepackage{geometry}` needs to move to beforethe custom preamble into `TexManager._get_preamble()`, and thus wecan't pass the dvips option to it anymore, but fortunately dvips isdocumented as the default driver anyways (section 5.6 of `geometry`docs). Also, in order to keep everything under 79 characters wide,change `{72in,72in}` to just `72in` (which is synonymous per section4.3.3 of `geometry` docs).Also insert some extra newlines in the generated tex file for ease ofdebugging.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free tosuggest an improvement. |
Fix use of psfrags in ps backend + usetex.Conflicts:lib/matplotlib/backends/backend_ps.py - near by change of rcParams -> mpl.rcParamslib/matplotlib/texmanager.py - do not implicitly backport rcParam deprecations
Looks like psfrags interacts badly with
\newgeometry
, so we need touse
\geometry
instead in the custom preamble to set the paper size.In turn this means that
\usepackage{geometry}
needs to move to beforethe custom preamble into
TexManager._get_preamble()
, and thus wecan't pass the dvips option to it anymore, but fortunately dvips is
documented as the default driver anyways (section 5.6 of
geometry
docs). Also, in order to keep everything under 79 characters wide,
change
{72in,72in}
to just72in
(which is synonymous per section4.3.3 of
geometry
docs).Also insert some extra newlines in the generated tex file for ease of
debugging.
Closes#16898; sorry I don't have a test for now.
PR Summary
PR Checklist