Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

update FAQ on how to register pandas converters#16906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromterencehonles:update-faq
Mar 27, 2020

Conversation

terencehonles
Copy link
Contributor

PR Summary

pandas.tseries.converter no longer exists, and the individual converters are not part of the public API so this change updates the documentation to reflect how to properly register the pandas converters with matplotlib.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR & it's fine as is. This is my suggestion but I didn't want to overstep by directly committing the changes:

If you prefer the pandas converters and locators, you can register them.
This is done automatically when calling a pandas plot function and may be unnecessary
when using pandas instead of matplotlib directly. ::

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with@story645 that the parentheses could be dropped.

`pandas.tseries.converter` no longer exists, and the individual converters arenot part of the public API so this change updates the documentation to reflecthow to properly register the pandas converters with matplotlib.
@terencehonles
Copy link
ContributorAuthor

Done

@QuLogicQuLogic added this to the3.2-doc milestoneMar 26, 2020
@QuLogicQuLogic merged commit5e74fb4 intomatplotlib:masterMar 27, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 27, 2020
QuLogic added a commit that referenced this pull requestMar 27, 2020
…906-on-v3.2.1-docBackport PR#16906 on branch v3.2.1-doc (update FAQ on how to register pandas converters)
@terencehonlesterencehonles deleted the update-faq branchApril 9, 2020 04:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@story645story645story645 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2-doc
Development

Successfully merging this pull request may close these issues.

3 participants
@terencehonles@QuLogic@story645
[8]ページ先頭
©2009-2025 Movatter.jp