Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Turn fontdict & minor into kwonly parameters for set_{x,y}ticklabels.#16904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is consistent with the general trend of making "minor" a kwonlyparam, and will help in making set_{x,y}ticklabels just a thin wrapperaround Axis.set_ticklabels.| @@ -3422,6 +3422,7 @@ def get_xticklabels(self, minor=False, which=None): | |||
| """ | |||
| return self.xaxis.get_ticklabels(minor=minor, which=which) | |||
| @cbook._make_keyword_only("3.3", "fontdict") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But you didn't markminor, does this propagate to the remaining parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes. (The only way to passminor positionally would be to also passfontdict positionally.)
This is consistent with the general trend of making "minor" a kwonly
param, and will help in making set_{x,y}ticklabels just a thin wrapper
around Axis.set_ticklabels (#16903).
PR Summary
PR Checklist