Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Warn in the docs that MouseEvent.key can be wrong.#16892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:mouseevent-key
Mar 24, 2020

Conversation

anntzer
Copy link
Contributor

PR Summary

MouseEvent.key is just derived from the last key_press_event/key_release_event, so will be wrong e.g. if one presses a key while the canvas does not have focus, then move the mouse to the canvas and clicks.

In general I think it isn't possible to know what keys are pressed while a mouse even occurs; one can only have a list ofmodifiers (ctrl/alt/shift). There's a PR adding that at#6159 but it needs a bit of work, so let's document the limitation for now.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.3.0 milestoneMar 23, 2020
@QuLogicQuLogic merged commit7c400e9 intomatplotlib:masterMar 24, 2020
@anntzeranntzer deleted the mouseevent-key branchMarch 24, 2020 08:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@tacaswell@timhoffm@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp