NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Enables hatch alpha on SVG#16890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 3 commits intomatplotlib:masterfrommnmelo:patch-1

Mar 24, 2020

Merged

Enables hatch alpha on SVG#16890

QuLogic merged 3 commits intomatplotlib:masterfrommnmelo:patch-1

Mar 24, 2020

+83 −74

Conversation

Copy link

Contributor

mnmelo commentedMar 23, 2020•
edited
Loading

PR Summary

Partially addresses#16883

Addsstroke-opacity to hatch, but only if it's set to anything less than 1.

Unsure if it warrants a new figure for test comparison (svgs are small, though). Alternatively, could be tested against the PNG output, which is correct now (but may miss future simultaneous breakage).

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

mnmelo added2 commits

March 23, 2020 19:22

Enables hatch alpha on SVG

003ea0b

Partially addressesmatplotlib#16883 Adds `stroke-opacity` to hatch, but only if it's set to anything less than 1.

Updated test baseline image

58f1527

Copy link

ContributorAuthor

mnmelo commentedMar 23, 2020

Turns out that the testtest_artist.py::test_clipping[svg] already used an image with a hatched patch, with alpha. Updated that image, and now it checks for the case in this PR too.

anntzer added the backend: svg label

Mar 23, 2020

anntzer added this to thev3.3.0 milestone

Mar 23, 2020

anntzer approved these changes

Mar 23, 2020

View reviewed changes

Copy link

Contributor

anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if ci passes.

tacaswell approved these changes

Mar 23, 2020

View reviewed changes

Copy link

Member

tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Might be worth adding a whats new entry.

👍 that we already had a test that exercised this so we don't have to add a new test :)

Copy link

ContributorAuthor

mnmelo commentedMar 24, 2020

Hmm, this is erroring because it runs over the Azure Pipelines 60 min limit.
What's the procedure now?

QuLogic reviewed

Mar 24, 2020

View reviewed changes

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If you add the what's new entry and push, then there's no need to worry about the broken build.

lib/matplotlib/backends/backend_svg.py OutdatedShow resolvedHide resolved

Cleaned code and added a whats_new

c939331

Copy link

ContributorAuthor

mnmelo commentedMar 24, 2020

There. Let me know if you think thewhat's new should read differently (there really isn't much to say other than hatch alpha now works in SVG). Perhaps noteworthy is that SVG now seems to be the only vector output backed that can do the hatch alpha (I'm not entirely sure, though).