Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Path length#16888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Path length#16888
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e2f403a
to8d1e757
Compare23ffc9f
to0dbef92
CompareSince this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
@brunobeltran your work on these path PRs was great. Appreciate that you have a real job now, but if you have any time to finish them, it would be a real service. Maybe your company allows donated hours? |
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
4c50daf
to5c89fb3
Compare
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
To correctly compute the center of mass of a path (to e.g. center a marker correctly), we need to correctly compute the path lengths of the component Bezier curves.
Roadmap:
#16812 (*) <-#16832 (*) <-#16859 (*) <- (This PR) (*) <-#16889 (*) <-#16891 (MarkerStyle improvements!)
"<-" means "depends on", and "(*)" marks PRs whose implementations are complete and fully ready for review.
PR Checklist