Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Path length#16888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
brunobeltran wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
frombrunobeltran:path_length
Open

Conversation

brunobeltran
Copy link
Contributor

@brunobeltranbrunobeltran commentedMar 23, 2020
edited
Loading

PR Summary

To correctly compute the center of mass of a path (to e.g. center a marker correctly), we need to correctly compute the path lengths of the component Bezier curves.

Roadmap:

#16812 (*) <-#16832 (*) <-#16859 (*) <- (This PR) (*) <-#16889 (*) <-#16891 (MarkerStyle improvements!)

"<-" means "depends on", and "(*)" marks PRs whose implementations are complete and fully ready for review.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@brunobeltranbrunobeltranforce-pushed thepath_length branch 9 times, most recently frome2f403a to8d1e757CompareMarch 31, 2020 02:03
@brunobeltranbrunobeltranforce-pushed thepath_length branch 3 times, most recently from23ffc9f to0dbef92CompareApril 9, 2020 05:01
@jklymakjklymak marked this pull request as draftJuly 23, 2020 03:17
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actionsgithub-actionsbot added the status: inactiveMarked by the “Stale” Github Action labelJul 14, 2023
@jklymak
Copy link
Member

@brunobeltran your work on these path PRs was great. Appreciate that you have a real job now, but if you have any time to finish them, it would be a real service. Maybe your company allows donated hours?

@github-actionsgithub-actionsbot removed the status: inactiveMarked by the “Stale” Github Action labelJul 17, 2023
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actionsgithub-actionsbot added the status: inactiveMarked by the “Stale” Github Action labelSep 18, 2023
@greglucas
Copy link
Contributor

@rossbar@ksunden - Here is the PR I wanted to link you to for the bezier path things you were asking about today at the NumFOCUS summit. I think if anyone wants to pick this work up it would be very welcome and it has been laid out really nicely in the PR descriptions.

rossbar reacted with heart emoji

@story645story645 added topic: path handling status: orphaned PR keepItems to be ignored by the “Stale” Github Action and removed status: waiting for other PR status: inactiveMarked by the “Stale” Github Action labelsSep 6, 2024
@greglucasgreglucasforce-pushed thepath_length branch 2 times, most recently from4c50daf to5c89fb3CompareOctober 30, 2024 15:36
@greglucasgreglucas marked this pull request as ready for reviewOctober 30, 2024 15:39
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keepItems to be ignored by the “Stale” Github Actionstatus: orphaned PRstatus: work in progresstopic: path handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@brunobeltran@jklymak@greglucas@QuLogic@story645

[8]ページ先頭

©2009-2025 Movatter.jp