Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Unbreak CI by xfailing wxAgg test on macOS#16870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromtimhoffm:xfail
Mar 23, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

This is a stopgap for#16849, which does not yet have a solution. We just xfail the test for now so that other PRs pass CI.

@timhoffmtimhoffm changed the titleUnbreak CI by xfailingUnbreak CI by xfailing wxAgg test on macOSMar 22, 2020
@tacaswelltacaswell added this to thev3.2.2 milestoneMar 23, 2020
@tacaswell
Copy link
Member

The travis failure is a known file system race (test_loglog_nonpos[png-True]) that I think we have PR in flight to prevent.

@tacaswelltacaswell merged commit7352a13 intomatplotlib:masterMar 23, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 7352a13612a7bf6c3463edeec3e14c0490341a1b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16870: Unbreak CI by xfailing wxAgg test on macOS'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16870-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR#16870 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestMar 23, 2020
Merge pull requestmatplotlib#16870 from timhoffm/xfailCI: Unbreak CI by xfailing wxAgg test on macOSConflicts:  lib/matplotlib/tests/test_backends_interactive.py    - Other improvements to messages when skipping tests frombc155f0 near by.  Did not      implicitly backport other changes.
@timhoffmtimhoffm deleted the xfail branchMarch 23, 2020 15:24
tacaswell added a commit that referenced this pull requestMar 23, 2020
…-v3.2.xBackport PR#16870: Unbreak CI by xfailing wxAgg test on macOS
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

2 participants
@timhoffm@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp