Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Don't pretend to support old pythons in setup.py.#16837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
setup.py uses f-strings, so it fails with SyntaxError on Py<3.6, solet's not pretend to support older Pythons there.(The alternative would be to only put the version check in setup.py andthen move *everything* else into setupext.py, which may not be sillyeither?)
If anything,#16733 seems to prove that we need to keep the check inlonger. Python 2 was only just let go this year. |
But the point is that the check is actually not doing its job, because if you're running setup.py in an old Python you get the syntax error even before the check runs. |
The point is to fix that other syntax error and not to add more incompatibility? |
anntzer commentedMar 20, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This is bound to break regularly again unless we actually test that. |
The jquery stuff and command definitions surely should go into setupext.py; as well as the package collection. However I would leave |
Since we got another report about the |
Sounds fair. |
setup.py uses f-strings, so it fails with SyntaxError on Py<3.6, so
let's not pretend to support older Pythons there (see also#16733).
(The alternative would be to only put the version check in setup.py and
then moveeverything else into setupext.py, which may not be silly
either?)
PR Summary
PR Checklist