Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't pretend to support old pythons in setup.py.#16837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:setuppyver

Conversation

anntzer
Copy link
Contributor

setup.py uses f-strings, so it fails with SyntaxError on Py<3.6, so
let's not pretend to support older Pythons there (see also#16733).

(The alternative would be to only put the version check in setup.py and
then moveeverything else into setupext.py, which may not be silly
either?)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

setup.py uses f-strings, so it fails with SyntaxError on Py<3.6, solet's not pretend to support older Pythons there.(The alternative would be to only put the version check in setup.py andthen move *everything* else into setupext.py, which may not be sillyeither?)
@anntzeranntzer added this to thev3.3.0 milestoneMar 19, 2020
@QuLogic
Copy link
Member

If anything,#16733 seems to prove that we need to keep the check inlonger. Python 2 was only just let go this year.

timhoffm reacted with thumbs up emoji

@anntzer
Copy link
ContributorAuthor

But the point is that the check is actually not doing its job, because if you're running setup.py in an old Python you get the syntax error even before the check runs.

@timhoffm
Copy link
Member

The point is to fix that other syntax error and not to add more incompatibility?

@anntzer
Copy link
ContributorAuthor

anntzer commentedMar 20, 2020
edited
Loading

The point is to fix that other syntax error

This is bound to break regularly again unless we actually test that.
If we care about this use case I would suggest that we just move everything to setupext.py with just a version check in setup.py before importing setupext (which is fine too; do you agree with this plan?).

@timhoffm
Copy link
Member

The jquery stuff and command definitions surely should go into setupext.py; as well as the package collection. However I would leavesetup() in place. That's where people expect it.

@QuLogic
Copy link
Member

Since we got another report about theSyntaxError, I don't think we're ready to be removing this check. I've opened the above-mentioned PR to fix the syntax errors instead. I'm going to close this for now.

@QuLogicQuLogic closed thisApr 8, 2020
@anntzeranntzer deleted the setuppyver branchApril 8, 2020 21:45
@anntzer
Copy link
ContributorAuthor

Sounds fair.

@QuLogicQuLogic modified the milestones:v3.3.0,unassignedJul 9, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp