Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Disable draw_foo methods on renderer used to estimate tight extents.#16734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:tightdisabledraw
Mar 14, 2020

Conversation

anntzer
Copy link
Contributor

For the pgf backend, in particular draw_image() cannot succeed because
that needs actual filesystem access (to set up \includegraphics).

I think this is a better solution than#16732 toclose#16731, and should work both on master and backported to 3.2.

Note that this disabling of draw_foo methods was already done previously, in a piecemeal fashion, athttps://github.com/matplotlib/matplotlib/blob/v3.2.0/lib/matplotlib/backends/backend_pgf.py#L422 or (in a different fashion) athttps://github.com/matplotlib/matplotlib/blob/v3.2.0/lib/matplotlib/backends/backend_ps.py#L924.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelMar 11, 2020
@anntzeranntzer added this to thev3.2.1 milestoneMar 11, 2020
@anntzeranntzer mentioned this pull requestMar 11, 2020
6 tasks
@QuLogic
Copy link
Member

Doesn't the renderer get cached, and thus needs these methods restored?

@anntzer
Copy link
ContributorAuthor

The renderer gets swapped out later (in print_method) by a real one. This was already the case before: thedryrun renderer would likewise first be cached for tight bbox computations, then swapped out by print_method.

For the pgf backend, in particular draw_image() cannot succeed becausethat needs actual filesystem access (to set up \includegraphics).
@QuLogicQuLogic merged commit4d8063f intomatplotlib:masterMar 14, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 14, 2020
QuLogic added a commit that referenced this pull requestMar 14, 2020
…734-on-v3.2.xBackport PR#16734 on branch v3.2.x (Disable draw_foo methods on renderer used to estimate tight extents.)
@anntzeranntzer deleted the tightdisabledraw branchMarch 14, 2020 11:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm left review comments

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.

PGF backend + savefig.bbox results in I/O error in 3.2
4 participants
@anntzer@QuLogic@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp