Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make test_imagegrid_cbar_mode_edge less flaky.#16656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromQuLogic:flaky-test
Mar 7, 2020

Conversation

QuLogic
Copy link
Member

PR Summary

Since parametrizing the test allows it to run in parallel, this makes it flaky, as one process can overwrite the test result image of another.

Our standard way for dealing with tests that use the same baseline image is to pass duplicate filenames toimage_comparison, because that is serialized.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Feel free to merge with or without tim's suggestion.
It may make sense to add some machinery in image_comparison to check whether it's overwriting itself? (not in a "controlled" case like here after the PR when the same file is listed twice, but rather in a case where it doesn't expect such an overwrite and is likely due to parametrization) Not sure how complex this would be to implement, and therefore whether it's worth the trouble...

Since parametrizing the test allows it to run in parallel, this makes itflaky, as one process can overwrite the test result image of another.Our standard way for dealing with tests that use the same baseline imageis to pass duplicate filenames to `image_comparison`, because that isserialized.
@QuLogicQuLogic merged commit25cb0b0 intomatplotlib:masterMar 7, 2020
@QuLogicQuLogic deleted the flaky-test branchMarch 7, 2020 06:02
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 7, 2020
QuLogic added a commit that referenced this pull requestMar 7, 2020
…656-on-v3.2.xBackport PR#16656 on branch v3.2.x (Make test_imagegrid_cbar_mode_edge less flaky.)
@QuLogicQuLogic mentioned this pull requestMar 11, 2020
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp