Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
fix tightbbox to account for markeredgewidth#16607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
brunobeltran wants to merge33 commits intomatplotlib:masterfrombrunobeltran:markeredgewidth-bbox-fix
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes fromall commits
Commits
Show all changes
33 commits Select commitHold shift + click to select a range
90dce86
fix tightbbox to account for markeredgewidth
brunobeltran5ed49fd
cleanup definition of "point" marker
brunobeltran9088cf4
document unit_regular_polygon
brunobeltranfd6df9b
untested version of new code to get marker bbox
brunobeltranef2fefd
fix for marker bbox now works except for on miter
brunobeltrandb033e4
fixed mis-ordered PathEndAngles for ticks
brunobeltran7e41bf5
flake8 for new markers code
brunobeltranf1014b5
factor marker bbox code to be within MarkerStyles
brunobeltran42cc5db
bugfix, forgot self in MarkerStyle.get_centered_bbox
brunobeltran8fcb223
misc bugfixes after factoring get_centered_bbox
brunobeltrand95e4d8
markers bbox code visually tested, now works
brunobeltran4592cda
flake8 for new markers bbox code
brunobeltranc08826e
fixed formula for miter marker bbox, bevel broke
brunobeltran7f9db16
bugfix caret bbox calculation, incorrect angles
brunobeltran1805dc7
fixed star tip angle in marker bbox calculation
brunobeltrana13598d
test marker bbox. failing here, pass in jupyter
brunobeltran0f7300a
bugfix so markers bbox api stays in pts units
brunobeltrand6f1571
forgot to push new test references images up
brunobeltran2bee048
cleanup variable name consistency
brunobeltran66694a0
use conversion not magic nums for line get_extents
brunobeltranc4a45de
iter_curves: iterate over path more conveniently
brunobeltranc5bdd8d
helper functions for bezier curve zeros/tangents
brunobeltran41f268e
CornerInfo in bezier.py, should be path.py
brunobeltran637a7f2
update marker bbox to work for arbitrary paths
brunobeltran5ac9114
bugfix, new marker bbox code now runs, untested
brunobeltranef36ec2
pyflake fixes for marker bbox code
brunobeltran82e3c12
cleanup path/bezier to prevent import triangle
brunobeltran8585eca
fix prev commit, make split_in_out method of Path
brunobeltran54e3a3e
generalized path bbox code tested on some markers
brunobeltranb390653
path bbox now works for all markers but "pixel"
brunobeltran85a3050
reorg'd path/bezier code now builds docs no errors
brunobeltran79aa3b7
cleanup docstrings of stroked path bbox code
brunobeltran1ea37be
fixed sphinx warnings in path.py's docstrings
brunobeltranFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
154 changes: 63 additions & 91 deletionslib/matplotlib/bezier.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9 changes: 7 additions & 2 deletionslib/matplotlib/lines.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
48 changes: 43 additions & 5 deletionslib/matplotlib/markers.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
19 changes: 9 additions & 10 deletionslib/matplotlib/patches.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.