Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

super hacky fix to issue #1310#1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

tacaswell
Copy link
Member

The last entry in locs is laundered through val = float(str(val))

issue#1310

@WeatherGod
Copy link
Member

Are we even able to assume that MultipleLocator deals only with numerical values?

@tacaswell
Copy link
MemberAuthor

Ithink that if you tried to put any other type in it would be cause issues going through theBase class.

@mdboom
Copy link
Member

This seems worthy of backporting to 1.2.x.

The last entry in locs is laundered through val = float(str(val))
@tacaswell
Copy link
MemberAuthor

re-based to v1.2.x

@dhyams
Copy link
Contributor

I really wouldn't do this. I'll admit that I'm not sure what the right fix is yet, but this particular fix gives very little control over when the last tick appears and when it doesn't. What if I'm plotting things at very small scale, such that the 1e-15 matters?

I'll go digging, but there has to be some code somewhere that is doing the chopping of the locator "locs" to the current view limits. It's that code that needs to have a proper tolerance implemented, if it doesn't already.

@WeatherGod
Copy link
Member

@dhyams That is an extremely good point and should bethe reason not to accept this PR.

@dhyams
Copy link
Contributor

I have submitted another pull request to address this problem, as an alternative to this one.

#1686

@dmcdougalldmcdougall mentioned this pull requestJan 27, 2013
@dmcdougall
Copy link
Member

I feel that#1686 poses a slightly more appropriate solution so I'm going to close this PR in favour of#1686.

If@tacaswell (or anybody else) feels that this PR is indeed preferred over#1686, please feel free to re-open this.

@tacaswell
Copy link
MemberAuthor

I hope my feelings about this patch is clear from the name of the PR.

On Sun, Jan 27, 2013 at 1:00 PM, Damon McDougall
notifications@github.comwrote:

I feel that#1686https://github.com/matplotlib/matplotlib/issues/1686poses a slightly more appropriate solution so I'm going to close this PR in
favour of#1686#1686.

If@tacaswellhttps://github.com/tacaswell (or anybody else) feels that
this PR is indeed preferred over#1686#1686,
please feel free to re-open this.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1659#issuecomment-12759174.

Thomas Caswell
tcaswell@gmail.com

@tacaswelltacaswell deleted the issue_1310_fix branchAugust 14, 2014 00:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.x
Development

Successfully merging this pull request may close these issues.

5 participants
@tacaswell@WeatherGod@mdboom@dhyams@dmcdougall

[8]ページ先頭

©2009-2025 Movatter.jp