Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Merge pull request #16404 from jklymak/fix-add-base-symlognorm#16541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merge pull request #16404 from jklymak/fix-add-base-symlognorm#16541
Uh oh!
There was an error while loading.Please reload this page.
Conversation
FIX: add base kwarg to symlognorConflicts:doc/api/next_api_changes/behaviour.rst - moved to doc/api/prev_api_changes/api_changes_3.2.0/behavior.rst and re-worded.lib/matplotlib/colors.py - implicitly backported converting the docstring to numpy doc style. Re-worded new docstring
If that's a backport, it be merged. |
I changed the wording a bit so even though this is a backport, it should be reviewed as a normal PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since there are some changes, here are a few suggestions.
Uh oh!
There was an error while loading.Please reload this page.
lib/matplotlib/colors.py Outdated
| half of the linear range. For example, when *linscale* == 1.0 | ||
| (the default), the space used for the positive and negative halves | ||
| of the linear range will be equal to a decade in the logarithmic | ||
| range if ``base=10``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A small tweak (to the original) for the example sentence, but instead of "When x, then y, if z", it'd be better to put the conditions together as "When x and z, then y."
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
lib/matplotlib/colors.py Outdated
| If not given, defaults to ``np.e``, consistent with prior | ||
| behavior and warns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The parenthetical is a bit confusing, perhaps:
| Ifnotgiven,defaultsto``np.e``,consistentwithprior | |
| behaviorandwarns. | |
| Ifnotgiven,defaultsto``np.e`` (consistentwithpriorbehavior),andwarns. |
Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Should some of these suggestions be pulled forward into master? |
@jklymak Yes, I'll take care of that when I merge 3.2.x up to master. |
FIX: add base kwarg to symlognor
Conflicts:
doc/api/next_api_changes/behaviour.rst
- moved to
doc/api/prev_api_changes/api_changes_3.2.0/behavior.rst and re-worded.
lib/matplotlib/colors.py
- implicitly backported converting the docstring to numpy
doc style. Re-worded new docstring
PR Summary
PR Checklist