Currently, we default to hist.bins=10 which happens to match the numpy
default. However, there is some discussion about changing the numpy
default. This adds the option of fall back to "what numpy does by default"
by default.

Changing the default currently has no effect, as the numpy default is
the same as our ould default, but will future-proof us to follow numpy
if / when they change their default.

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

tacaswell added2 commits

February 11, 2020 08:51

ENH: allow hist.bins to follow the numpy default

5225734

Currently, we default to hist.bins=10 which happens to matchthe numpy default.  However, there is some discussion about changingthe numpy default.  This adds the option of fall back to "what numpydoes by default" by default.

API: make the default hist.bins be 'np_default'

97bf33d

This will have no effect, as the numpy default is currently the sameas our default, but will future-proof us to follow numpy if / whenthey change their default.

tacaswell added this to thev3.3.0 milestone

Feb 11, 2020

tacaswell mentioned this pull request

Feb 11, 2020

Request: change hist bins default to 'auto'#16403

Closed

jklymak reviewed

Feb 11, 2020

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall this seems fine but needs docs. I think this needs a what’s new? And the new kwarg value need an entry in the docstring. Probably the template comment needs to be changed

Copy link

Contributor

amueller commentedFeb 14, 2020

Ok so this changes the default as well, right?

QuLogic added the status: needs rebase label

May 5, 2020

tacaswell modified the milestones:v3.3.0,v3.4.0

May 21, 2020

Copy link

MemberAuthor

tacaswell commentedMay 21, 2020

Punting to 3.4 as I don't think this is urgent (as I don't think there is a pending change to the numpy default coming).

jklymak marked this pull request as draft

September 10, 2020 15:43

QuLogic modified the milestones:v3.4.0,v3.5.0

Jan 21, 2021

QuLogic modified the milestones:v3.5.0,v3.6.0

Aug 23, 2021

timhoffm modified the milestones:v3.6.0,unassigned

Apr 30, 2022

story645 modified the milestones:unassigned,needs sorting

Oct 6, 2022

Copy link

github-actionsbot commentedJul 10, 2023

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.