When I wrote this code ~4.5 years ago I was a bit cranky and used a
very sarcastic variable name (snowflake) to handle a class of special
cases when parsing math text. It has recently come to light that this
name can make it into user visible error messages. This renames the
variable to a less sarcastic and more descriptive variable name (it
handles the case of symbols who's names start with a valid accent; we
should parse it as the symbol, not an accent on the rest of the symbol
name).

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant

tacaswell added this to thev3.3.0 milestone

Feb 6, 2020

anntzer reviewed

Feb 6, 2020

View reviewed changes

lib/matplotlib/mathtext.py OutdatedShow resolvedHide resolved

tacaswell force-pushed themnt_rename_internals branch from49b95c4 to6d99af6Compare

February 6, 2020 19:36

jklymak approved these changes

Feb 6, 2020

View reviewed changes

Copy link

codecovbot commentedFeb 6, 2020•
edited
Loading

Codecov Report

Merging#16425 intomaster willdecrease coverage by0.30%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master   #16425      +/-   ##==========================================- Coverage   80.85%   80.54%   -0.31%==========================================  Files         307      307                Lines       75745    74407    -1338       Branches     9690     9688       -2     ==========================================- Hits        61245    59933    -1312+ Misses      11961    11934      -27- Partials     2539     2540       +1

Impacted Files	Coverage Δ
lib/matplotlib/testing/jpl_units/StrConverter.py	`15.55% <0.00%> (-5.28%)`	⬇️
lib/matplotlib/testing/jpl_units/EpochConverter.py	`69.69% <0.00%> (-4.67%)`	⬇️
lib/matplotlib/docstring.py	`65.00% <0.00%> (-3.19%)`	⬇️
...b/matplotlib/testing/jpl_units/UnitDblConverter.py	`65.85% <0.00%> (-2.33%)`	⬇️
lib/matplotlib/backend_managers.py	`20.95% <0.00%> (-2.30%)`	⬇️
lib/matplotlib/pyplot.py	`71.72% <0.00%> (-1.18%)`	⬇️
lib/matplotlib/animation.py	`66.71% <0.00%> (-1.08%)`	⬇️
lib/matplotlib/units.py	`88.57% <0.00%> (-1.04%)`	⬇️
lib/matplotlib/backends/backend_webagg.py	`59.14% <0.00%> (-0.98%)`	⬇️
lib/matplotlib/backend_tools.py	`32.57% <0.00%> (-0.94%)`	⬇️
... and152 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee4dbf4e...9a7ddd3. Read thecomment docs.

MNT: rename internal variable

9a7ddd3

When I wrote this code ~4.5 years ago I was a bit cranky and used avery sarcastic variable name (snowflake) to handle a class of specialcases when parsing math text.  It has recently come to light that thisname can make it into user visible error messages.  This renames thevariable to a less sarcastic and more descriptive variable name (ithandles the case of symbols who's names start with a valid accent; weshould parse it as the symbol, not an accent on the rest of the symbolname).

tacaswell force-pushed themnt_rename_internals branch from6d99af6 to9a7ddd3Compare

February 6, 2020 20:56