Should probably have made it to 3.2 instead due to#16678 (#14401), so I milestoned this to 3.2.1. If we agree about the remilestone I will update the version numbers in the diffs.

👍 but the deprecation notes should go in the 3.2 file.

I don't think this is going to backport cleanly as the "pull defaults from the sample file" logic is not on the 3.2.x branch. It may have to be re-written on that branch.

that's fine, I'll open a separate pr for 3.2.1.
edit: done at#16722; also moved the deprecation note.

let's wait for that other pr to be merged

looks like all's left after the rebase is just the changelog note?

We should back out most of the changes from#16722

Ah, I see, done.

Commit message needs updating.

I guess I vaguely lost track of the deprecation status here. The diff says "remove the datapath" kwarg, but it's clearly not actually removed, just deprecated? so this just removes the ability to set it in the matplotlibrc. But perhaps in that case we may as well wait for the entire deprecation period to be elapsed and strip out the rcparam all at once?

So just wait for 3.4 then, and remove it all?

I guess so,@tacaswell?

Re-milestoned to 3.4 as this is going to take some time to sort out and remind our selves what is going on and it is better to leave a deprecating thing sitting around warning for an extra cycle that it is to pull the rug out from under someone accidentally.

@tacaswell@anntzer can you figure out what needs to be done here?

Are we fine with completely stripping outrcParams["datapath"] for 3.4? if so I can post a PR.

Yes to stripping out datapath for 3.4, we have given fair warning on this.

Superseded by#19340.