NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Don't import rcParams but rather use mpl.rcParams.#16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

timhoffm merged 1 commit intomatplotlib:masterfromanntzer:rcimport

Feb 4, 2020

Merged

Don't import rcParams but rather use mpl.rcParams.#16406

timhoffm merged 1 commit intomatplotlib:masterfromanntzer:rcimport

Feb 4, 2020

Conversation

Copy link

Contributor

anntzer commentedFeb 4, 2020

This helps letting modules be imported early in the init process, even
before the rcParams object is constructed.

I didn't change all cases, just those needed to make matplotlib.scale
importable into matplotlib.colors (per#16386).

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Don't import rcParams but rather use mpl.rcParams.

f038112

This helps letting modules be imported early in the init process, evenbefore the rcParams object is constructed.I didn't change all cases, just those needed to make matplotlib.scaleimportable into matplotlib.colors.

Copy link

codecovbot commentedFeb 4, 2020

Codecov Report

Merging#16406 intomaster willdecrease coverage by0.00%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master   #16406      +/-   ##==========================================- Coverage   80.85%   80.85%   -0.01%==========================================  Files         307      307                Lines       75745    75748       +3       Branches     9690     9691       +1     ==========================================+ Hits        61245    61246       +1- Misses      11961    11962       +1- Partials     2539     2540       +1

Impacted Files	Coverage Δ
lib/matplotlib/__init__.py	`67.18% <0.00%> (-0.18%)`	⬇️
lib/matplotlib/spines.py	`70.45% <0.00%> (-0.10%)`	⬇️
lib/matplotlib/pyplot.py	`72.86% <0.00%> (-0.04%)`	⬇️
lib/matplotlib/cbook/__init__.py	`76.87% <0.00%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updateb47fc9d...f038112. Read thecomment docs.