Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix usetex_baseline_test.#16373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Codecov Report
@@ Coverage Diff @@## master #16373 +/- ##==========================================- Coverage 80.85% 80.45% -0.41%========================================== Files 307 307 Lines 75745 74403 -1342 Branches 9690 9686 -4 ==========================================- Hits 61245 59859 -1386- Misses 11961 11996 +35- Partials 2539 2548 +9
Continue to review full report at Codecov.
|
You must be on codecov’s naughty list ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Despite the name, this isn't actually a test but a demo in the docs.
@tacaswell good to go? I have a followup PR which actually fixes the baseline problem in all cases :p |
| class Axes(maxes.Axes): | ||
| @maxes.subplot_class_factory | ||
| class Subplot(maxes.Axes): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe use another name likeLatexSubplot or similar to make it more explicit that this is something special and not to be confused with our regular subplot semantics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
The previous version didn't actually compare usetex=False andusetex=True because usetex state is stored in the text instance, so fixthat. (The custom axes subclass remains necessary to comparetext.latex.preview=False and =True.)Also misc. cleanups.
edd2237 to9fa950cCompare
The previous version didn't actually compare usetex=False and
usetex=True because usetex state is stored in the text instance, so fix
that. (The custom axes subclass remains necessary to compare
text.latex.preview=False and =True.)
Also misc. cleanups.
old:
new:
PR Summary
PR Checklist