Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Pin docutils#16358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Pin docutils#16358
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
tacaswell approved these changesJan 28, 2020
I could have sworn I dealt with this someplace else recently... Will have to make sure we are careful on the branch merge up to not pull this forward. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
We have pinned sphinx<2 on the 2.2.x branch. As a follow-up we also have to pin docutils<0.16.
Docutils 0.16 introduced FutureWarnings on node list access:
https://sourceforge.net/p/docutils/mailman/message/36765733/
Code that circumvents these warnings was only introduced in sphinx 2.3 (sphinx-doc/sphinx#6887).
We have two options:
The former seems far easier and is thus what this PR does.
This is required to get 2.2.x docs build and in particular the prerequisite for#16352.