Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pin docutils#16358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:v2.2.xfromtimhoffm:pin-docutils
Jan 28, 2020
Merged

Pin docutils#16358

tacaswell merged 1 commit intomatplotlib:v2.2.xfromtimhoffm:pin-docutils
Jan 28, 2020

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedJan 28, 2020
edited
Loading

PR Summary

We have pinned sphinx<2 on the 2.2.x branch. As a follow-up we also have to pin docutils<0.16.

Docutils 0.16 introduced FutureWarnings on node list access:

/home/circleci/.local/lib/python3.5/site-packages/sphinx/util/nodes.py:94: FutureWarning:    The iterable returned by Node.traverse()   will become an iterator instead of a list in Docutils > 0.16.

https://sourceforge.net/p/docutils/mailman/message/36765733/

Code that circumvents these warnings was only introduced in sphinx 2.3 (sphinx-doc/sphinx#6887).

We have two options:

  • either limit docutils to <0.16
  • or pull sphinx for this branch up (which probably needs additional backports, because we had a reason to pin sphinx.

The former seems far easier and is thus what this PR does.

This is required to get 2.2.x docs build and in particular the prerequisite for#16352.

@timhoffmtimhoffm added this to thev2.2.5 milestoneJan 28, 2020
@tacaswell
Copy link
Member

I could have sworn I dealt with this someplace else recently...

Will have to make sure we are careful on the branch merge up to not pull this forward.

@tacaswelltacaswell merged commit80c2280 intomatplotlib:v2.2.xJan 28, 2020
@timhoffmtimhoffm deleted the pin-docutils branchJanuary 29, 2020 06:16
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v2.2.5
Development

Successfully merging this pull request may close these issues.

2 participants
@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp