Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Make set_x/ymargin() update axes limits, just like margins().#16340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7ed0b3f to1e491daCompareWhat does the change to collections have to do with this? It seems unrelated, or at least unexplained. |
It's actually needed because autoscaling triggers in a place where it was previously missing, and exposes a floating point inaccuracy previously present (which was then amplified by the old round-numbers autolimits behavior). |
OK, probably would have been clearer in a separate commit, or at least mentioned in the commit message. |
1e491da tob5fd761Comparefair enough, edited the commit message. |
Previously, setting the margins via set_x/ymargin() would not updateaxes limits, unlike calling margins(). This appears to be a simpleoversight.The change in collections.py is necessary because the difference intiming at which autoscale is executed now exposed a floating pointinaccuracy (which gets amplified by the old round_numbers autolimitsmode).
The changes in collections.py were merged separately in#17206. |
Previously, setting the margins via set_x/ymargin() would not update
axes limits, unlike calling margins(). This appears to be a simple
oversight.
Closes#7093.
PR Summary
PR Checklist