Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

STY: Fix underindented continuation lines.#16279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:e128
Feb 25, 2020

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJan 21, 2020•
edited
Loading

I don't agree withall indent choices of pycodestyle but these look
mostly like improvements.

Not doing the corresponding fix for overindented lines because I thinkPyCQA/pycodestyle#569 needs to be fixed first.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.3.0 milestoneJan 21, 2020
# need to change the orientation.
self._locstrings = self._locstrings[::-1]
elif align != self._locstrings[0]:
raise ValueError('"{}" is not a valid axis orientation, '
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the logic here was incorrect (we already checked thatalign in self._locstrings).

@anntzeranntzerforce-pushed thee128 branch 2 times, most recently fromdfee54c to4f5cfdbCompareJanuary 24, 2020 08:19
@anntzeranntzerforce-pushed thee128 branch 2 times, most recently from14bc3ee toab61a38CompareJanuary 26, 2020 12:10
@anntzer
Copy link
ContributorAuthor

rebased

I don't agree with *all* indent choices of pycodestyle but these lookmostly like improvements.
@tacaswelltacaswell merged commit9895288 intomatplotlib:masterFeb 25, 2020
@anntzeranntzer deleted the e128 branchFebruary 25, 2020 08:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@timhoffm@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp