Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Move mplot3d autoregistration api changes to 3.2.#16272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromanntzer:mplot3dautoregister
Jan 21, 2020

Conversation

anntzer
Copy link
Contributor

This was wrongly put into the 3.1 notes.

Closes#16192.

Should perhaps also be backported to 3.1.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This was wrongly put into the 3.1 notes.
@anntzeranntzer added Documentation Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelsJan 20, 2020
@anntzeranntzer added this to thev3.2.0 milestoneJan 20, 2020
@dstansbydstansby modified the milestones:v3.2.0,v3.1-docJan 21, 2020
@dstansbydstansby merged commitef57d9e intomatplotlib:masterJan 21, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 ef57d9ef82ec069f1093bc69e3db2b658a9407d0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16272: Move mplot3d autoregistration api changes to 3.2.'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-16272-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR#16272 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@lumberbot-app
Copy link

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@anntzeranntzer deleted the mplot3dautoregister branchJanuary 21, 2020 11:35
QuLogic pushed a commit to QuLogic/matplotlib that referenced this pull requestFeb 13, 2020
@QuLogic
Copy link
Member

Well, this isn't getting into 3.1.3, but might as well backport to fix the website.

@QuLogic
Copy link
Member

@meeseeksdev backport to v3.2.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 13, 2020
dstansby added a commit that referenced this pull requestFeb 13, 2020
…272-on-v3.2.xBackport PR#16272 on branch v3.2.x (Move mplot3d autoregistration api changes to 3.2.)
@timhoffm
Copy link
Member

I think backporting to v3.2.x is enough.

tacaswell added a commit that referenced this pull requestFeb 16, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Labels
DocumentationRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1-doc
Development

Successfully merging this pull request may close these issues.

matplotlib 3.1.2: mplot3d must be explicitly imported to work
4 participants
@anntzer@QuLogic@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp