Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: AttributeError in TimerBase.start#16235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromsamschott:bugfix-TimerBase
Jan 15, 2020

Conversation

samschott
Copy link

PR Summary

When callingTimerBase.start with a new interval, an AttributeError is raised becauseTimerBase has no method_set_interval.

Don't callTimerBase._set_interval (does not exist) but set the propertyTimerBase .interval instead.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... when calling with new interval
Copy link
Contributor

@anntzeranntzer left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks like I missed that in#11698.
Milestoned as 3.2, but could even be backported to 3.1.

@anntzeranntzer added this to thev3.2.0 milestoneJan 15, 2020
@tacaswelltacaswell modified the milestones:v3.2.0,v3.1.3Jan 15, 2020
@tacaswelltacaswell merged commitc2cfdf3 intomatplotlib:masterJan 15, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 15, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 15, 2020
@tacaswell
Copy link
Member

Thanks for the fix@samschott ! The OSX test had timed out while failing to get hardware.

@samschott
Copy link
Author

Wow, you all have a quick response time! Thanks for merging.

Kojoley added a commit that referenced this pull requestJan 16, 2020
…235-on-v3.1.xBackport PR#16235 on branch v3.1.x (FIX: AttributeError in TimerBase.start)
Kojoley added a commit that referenced this pull requestJan 16, 2020
…235-on-v3.2.xBackport PR#16235 on branch v3.2.x (FIX: AttributeError in TimerBase.start)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.

4 participants
@samschott@tacaswell@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp