Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Expire deprecation of \stackrel#16206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Codecov Report
@@ Coverage Diff @@## master #16206 +/- ##==========================================- Coverage 80.87% 74.85% -6.02%========================================== Files 306 275 -31 Lines 75758 68664 -7094 Branches 9690 9686 -4 ==========================================- Hits 61268 51401 -9867- Misses 11953 14907 +2954+ Partials 2537 2356 -181
Continue to review full report at Codecov.
|
| @@ -93,7 +93,6 @@ | |||
| r'$\operatorname{cos} x$', # github issue #553 | |||
| r'$\sum _{\genfrac{}{}{0}{}{0\leq i\leq m}{0<j<n}}P\left(i,j\right)$', | |||
| r"$\left\Vert a \right\Vert \left\vert b \right\vert \left| a \right| \left\| b\right\| \Vert a \Vert \vert b \vert$", | |||
| r'$\mathring{A} \stackrel{\circ}{A} \AA$', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we leave in the test asr'$\mathring{A} \AA$', ? I don't think we other wise have coverage of those symbols and it will avoid the re-numbering of the tests which is very confusing.
If we really want to drop this test, we should leave aNone in place and filter it a bit farther down just before we feed paramaterize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
have an idea on how to avoid re-numbering everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Only modify the test.
anntzer commentedFeb 8, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Your patch looks fine to me. |
PR Summary
Like#16204, but for \stackrel.
PR Checklist