Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Expire deprecation of \mathcircled#16204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Needs a rebase
1950b2c to96465ebComparethanks, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Have an idea of how to avoid re-naming all of the test images.
My approval should be suspect given that I pushed code to this branch, but 👍 to the removal. I think it is better to accept a bit more complexity in generating the fixtures to avoid having to move many many files. |
anntzer commentedFeb 8, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Fixed a flake8 error, and additionally removed the corresponding entries in _mathtext_data.py. |
rebased to fix the deprecation conflicts, will merge when green. |
(may be worth withholding merges untilhttps://gitter.im/matplotlib/matplotlib?at=5e3e96051d23aa47aa003c3b is resolved (either way) in order to not make the history edit more complicated) |
Oh good, UI is showing us all of the extra commits, will fix. |
hmm, it is now not letting me force-push to this branch, sorry@anntzer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
needs to have bad commits removed, anyone can clear this and and anyone con merge on green.
rebased |
of course I just broke this by merging the stackrel PR. |
Use stubs in font_test_specs to avoid having to re-name all of thelater tests.
rebased |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
A slightly tricky one: a bunch of baseline images had to be renumbered because the mathtext tests just index baseline images by their ordinal number, but the mathcircled tests were in the middle... (yes, this is brittle, but I'm not going to refactor this now)
1st commit removes the now unused baselines; 2nd commit renumbers the rest (so that the motion is more obvious in the log). (Github show them as changed binaries, but they're actually all just deletes and renames.)
attn@timhoffm this may have been one of the issue you ran into in#15890.
PR Checklist