Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

UnCamelCase examples.#16201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:camelicide
Jan 13, 2020
Merged

Conversation

anntzer
Copy link
Contributor

The changes in basic_units are possible because the unit framework now
correctly handles unit subclasses, so we don't need to register
dynamically created subclasses (since#13536).

Followup tohttps://github.com/matplotlib/matplotlib/pull/16199/files; I think the only remaining cases are callback names in wx examples.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The changes in basic_units are possible because the unit framework nowcorrectly handles unit subclasses, so we don't need to registerdynamically created subclasses.
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was also unsure about the wx callback names. Does anybody know if there are common conventions for these?

@timhoffmtimhoffm added this to thev3.3.0 milestoneJan 13, 2020
@timhoffmtimhoffm merged commitec83125 intomatplotlib:masterJan 13, 2020
@anntzeranntzer deleted the camelicide branchJanuary 13, 2020 19:13
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp