NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Deprecate Artist.{set,get}_contains.#16200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 1 commit intomatplotlib:masterfromanntzer:contains

Mar 10, 2020

Merged

Deprecate Artist.{set,get}_contains.#16200

QuLogic merged 1 commit intomatplotlib:masterfromanntzer:contains

Mar 10, 2020

Conversation

Copy link

Contributor

anntzer commentedJan 13, 2020

I don't think it makes sense to allow overriding contains() checks
per instance -- and if someone really need that, they can use a custom
artist subclass or even just monkeypatch the contains method; if they
need it for pick events there's still Artist.set_picker which is not
going away.

This came in in8111a3a (2007) and was apparently never used or tested.

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added this to thev3.3.0 milestone

Jan 13, 2020

anntzer force-pushed thecontains branch from896dbb5 to7445281Compare

January 14, 2020 00:38

timhoffm approved these changes

Jan 14, 2020

View reviewed changes

anntzer force-pushed thecontains branch 3 times, most recently from0886e70 to5d7361bCompare

January 17, 2020 13:21

Copy link

Member

QuLogic commentedMar 9, 2020

This appears to need a rebase to get working CI (failures don't appear to be related, I think), but also there are many references to these functions indoc/api that maybe are unnecessary now?

Deprecate Artist.{set,get}_contains.

739aeb9

I don't think it makes sense to allow overriding contains() checksper instance -- and if someone really need that, they can use a customartist subclass or even just monkeypatch the contains method; if theyneed it for pick events there's still Artist.set_picker which is notgoing away.This came in in8111a3a (2007) and was apparently never used or tested.