Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Backport PR #16112 on branch v2.2.x (CI: Fail when failed to install dependencies)#16137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Kojoley
Copy link
Member

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@KojoleyKojoley added this to thev2.2.5 milestoneJan 7, 2020
…dep-install-failsCI: Fail when failed to install dependencies
@KojoleyKojoleyforce-pushed theauto-backport-of-pr-16112-on-v2.2.x branch frome2f126f toc1fba63CompareJanuary 9, 2020 15:59
This will move testing on travis to python3 (from python2), however Iam not sure it is worth the effort of moving brew on travis back topython2 so that we can in very short order delete this branch andclose out the 2.2.x series (now that python2 is EOL).
The brew configuration has bit-rotted
@tacaswell
Copy link
Member

I gave up and removed the OSX build and nightly, but added py38 on linux.

@Kojoley
Copy link
MemberAuthor

I think the OSX problem is inosx_image: xcode7.3 (removing was not backported here)

@tacaswell
Copy link
Member

Tried putting the osx build back and removing the offending line.

@Kojoley I don't want to force-push to your branch without your consent, but one of us should squash this history down to a handful of commits

@Kojoley
Copy link
MemberAuthor

I don't want to force-push to your branch without your consent

I have no problems with this.

one of us should squash this history down to a handful of commits

Squash and merge button on GitHub is not enough?

@tacaswelltacaswell merged commit5e13fa9 intomatplotlib:v2.2.xJan 20, 2020
@tacaswell
Copy link
Member

Fair enough, squashed and merged.

@KojoleyKojoley deleted the auto-backport-of-pr-16112-on-v2.2.x branchJanuary 20, 2020 17:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.5
Development

Successfully merging this pull request may close these issues.

3 participants
@Kojoley@tacaswell@NelleV
[8]ページ先頭
©2009-2025 Movatter.jp