Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Default to writing animation frames to a temporary directory.#16082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
(We could later deprecate clean_temp, as the user can simply pass anon-None frame_prefix to write temporary frames whereever they want andkeep them there.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not looked much into this, but it looks confusing thatframe_prefix determines cleanup butclear_temp as well. Is this really necessary?
I plan to deprecate clear_temp later. (One can't really support frame_prefix=None (i.e. tmpdir) + clear_temp=False without adding a completely separate code path for creating a tmpdir with mkdtemp so that it doesn't get deleted, but that seems just not worth it.) |
(We could later deprecate clean_temp, as the user can simply pass a
non-None frame_prefix to write temporary frames whereever they want and
keep them there.)
Redo of#3536 (see motivation there) and some of#11860, also solves#11863 (comment).
PR Summary
PR Checklist