Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleanup pcolor_demo.#16060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:pcolor_demo
Jan 1, 2020
Merged

Conversation

@anntzer
Copy link
Contributor

  • Set up the x, y arrays in simpler (IMO) ways.
  • Make imshow() use aspect="auto" rather than the default aspect=1,
    to make it more comparable with the pcolor plots.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm
Copy link
Member

flake8:

./examples/images_contours_and_fields/pcolor_demo.py:44:19: E203 whitespace before ':'./examples/images_contours_and_fields/pcolor_demo.py:44:26: E203 whitespace before ':'./examples/images_contours_and_fields/pcolor_demo.py:44:35: E203 whitespace before ':'./examples/images_contours_and_fields/pcolor_demo.py:44:42: E203 whitespace before ':'

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Make imshow() use aspect="auto" rather than the default aspect=1,
to make it more comparable with the pcolor plots.

IMHO, the purpose of this section is not to show that you can produce identical plots with these functions given the right kwargs. Instead, it should show how they plots are similar or different given the default settings. It would actually be good to describe what's similar/different. As of now the users have to compare the images and guess. If you don't want to go into describing, I recommend to leave this unchanged for now.

@anntzer
Copy link
ContributorAuthor

I added a small comment re: aspect="auto", because I think it's actually quite important: the point is that even for non-square pixels, you can use imshow, which is typically much more efficient than the various pcolor*, whereas I would guess many people believe imshow only works for square pixels.

- Set up the x, y arrays in simpler (IMO) ways.- Make imshow() use aspect="auto" rather than the default aspect=1,  to make it more comparable with the pcolor plots.
Copy link
Member

@timhoffmtimhoffm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The comparison could still use som more explanation, but merging as is as an incremental improvement.

@timhoffmtimhoffm added this to thev3.3.0 milestoneJan 1, 2020
@timhoffmtimhoffm merged commitb83d9d6 intomatplotlib:masterJan 1, 2020
@anntzeranntzer deleted the pcolor_demo branchJanuary 1, 2020 13:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp