Movatterモバイル変換

timhoffm commented

lib/mpl_toolkits/mplot3d/axis3d.py


		@property
		def v_interval(self):
		return self.get_view_interval()

		@d_interval.setter

Copy link

MemberAuthor

timhoffmDec 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This was actually a bug.

Copy link

Contributor

dopplershiftDec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would love to have a test for this...

Copy link

Contributor

anntzerDec 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should actually just deprecate them, as they are just mplot3d-specific synonyms for {get,set}_{view,data}_interval...

Copy link

MemberAuthor

timhoffmDec 31, 2019•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Moved to a separate PR#16053.

timhoffm force-pushed thecodestyle-cleanup branch frome7e490e to46949afCompare

December 30, 2019 14:03

jklymak approved these changes

anntzer reviewed

lib/matplotlib/dates.py OutdatedShow resolvedHide resolved

anntzer reviewed

lib/matplotlib/mathtext.pyShow resolvedHide resolved

anntzer reviewed

lib/mpl_toolkits/axisartist/axis_artist.pyShow resolvedHide resolved

Code style cleanup

fca65ed

timhoffm force-pushed thecodestyle-cleanup branch from46949af tofca65edCompare

December 31, 2019 10:40

timhoffm mentioned this pull request

Fix v_interval setter#16053

Merged

timhoffm added this to thev3.3.0 milestone

anntzer approved these changes

anntzer merged commitcab5dcc intomatplotlib:master