Jan 2, 2020 · Dec 22, 2019 · Dec 24, 2019 · Dec 23, 2019 · Dec 24, 2019
diff --git a/lib/matplotlib/category.py b/lib/matplotlib/category.py
        self._units = units_mapping

    def __call__(self, x, pos=None):
        return '' if pos is None else self.format_ticks([x])[0]
        """
        Return the category label string for tick val *x*.

        The position *pos* is ignored.
        """
        return self.format_ticks([x])[0]

    def format_ticks(self, values):
        r_mapping = {v: self._text(k) for k, v in self._units.items()}
diff --git a/lib/matplotlib/tests/test_category.py b/lib/matplotlib/tests/test_category.py
        labels = cat.StrCategoryFormatter(unit._mapping)
        for i, d in enumerate(ydata):
            assert labels(i, i) == d
            assert labels(i, None) == d

    @pytest.mark.parametrize("ydata", cases, ids=ids)
    @pytest.mark.parametrize("plotter", PLOT_LIST, ids=PLOT_IDS)
    def test_StrCategoryFormatterPlot(self, ax, ydata, plotter):
        plotter(ax, range(len(ydata)), ydata)
        for i, d in enumerate(ydata):
            assert ax.yaxis.major.formatter(i, i) == d
        assert ax.yaxis.major.formatter(i+1, i+1) == ""
        assert ax.yaxis.major.formatter(0, None) == ""
            assert ax.yaxis.major.formatter(i) == d
        assert ax.yaxis.major.formatter(i+1) == ""


 def axis_test(axis, labels):
Original file line number	Diff line number	Diff line change
Expand Up		@@ -138,7 +138,12 @@ def __init__(self, units_mapping):
		self._units = units_mapping

		def __call__(self, x, pos=None):
		return '' if pos is None else self.format_ticks([x])[0]
		"""
		Return the category label string for tick val x.

		The position pos is ignored.
		"""
		return self.format_ticks([x])[0]

		def format_ticks(self, values):
		r_mapping = {v: self._text(k) for k, v in self._units.items()}
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -154,15 +154,15 @@ def test_StrCategoryFormatter(self, ax, ydata):
		labels = cat.StrCategoryFormatter(unit._mapping)
		for i, d in enumerate(ydata):
		assert labels(i, i) == d
		assert labels(i, None) == d

		@pytest.mark.parametrize("ydata", cases, ids=ids)
		@pytest.mark.parametrize("plotter", PLOT_LIST, ids=PLOT_IDS)
		def test_StrCategoryFormatterPlot(self, ax, ydata, plotter):
		plotter(ax, range(len(ydata)), ydata)
		for i, d in enumerate(ydata):
		assert ax.yaxis.major.formatter(i, i) == d
		assert ax.yaxis.major.formatter(i+1, i+1) == ""
		assert ax.yaxis.major.formatter(0, None) == ""
		assert ax.yaxis.major.formatter(i) == d
		assert ax.yaxis.major.formatter(i+1) == ""
Copy link Member dstansbyDec 23, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Could you add a test that`ax.yaxis.major.formatter(i, None)` gives`d` as the label? (which it wouldn't do before this fix) Copy link ContributorAuthor sujanasowrirajanDec 24, 2019 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Thanks, I have updated the test.


		def axis_test(axis, labels):
Expand Down