The positionpos in__call__ can be ignored as the tick label is independent of position. So,__call__(value, None) would return a category label even ifpos isNone, which is the expected behavior.

The test case has been modified to pass only a single argument (sopos defaults toNone).

ignore pos in __call__

84c25d7

dstansby requested changes

Dec 23, 2019

View reviewed changes

Copy link

Member

dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! This looks good to me, would be good to add another test as I've suggested.

lib/matplotlib/tests/test_category.py

		assert ax.yaxis.major.formatter(i+1, i+1) == ""
		assert ax.yaxis.major.formatter(0, None) == ""
		assert ax.yaxis.major.formatter(i) == d
		assert ax.yaxis.major.formatter(i+1) == ""

Copy link

Member

dstansbyDec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you add a test thatax.yaxis.major.formatter(i, None) givesd as the label? (which it wouldn't do before this fix)

Copy link

ContributorAuthor

sujanasowrirajanDec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, I have updated the test.

dstansby added this to thev3.1.3 milestone

Dec 23, 2019

dstansby added the topic: categorical label

Dec 23, 2019

add test case for pos=None

9f1cae6

sujanasowrirajan requested a review fromdstansby

December 26, 2019 07:03

dstansby approved these changes

Dec 29, 2019

View reviewed changes

anntzer approved these changes

Jan 2, 2020

View reviewed changes

anntzer modified the milestones:v3.1.3,v3.2.0

Jan 2, 2020

Copy link

Contributor

anntzer commentedJan 2, 2020•
edited
Loading

Thanks :)
I think this can go to 3.2 as a new feature, feel free to backport if you disagree.

anntzer merged commit44ccb0e intomatplotlib:master

Jan 2, 2020

Copy link

lumberbot-appbot commentedJan 2, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v3.2.x$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 44ccb0ef499bde61326faafc063c8141cf00bf67

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #16006: Ignore pos in StrCategoryFormatter.__call__ to display correct label in the preview window '

Push to a named branch :

git push YOURFORK v3.2.x:auto-backport-of-pr-16006-on-v3.2.x

Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR#16006 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

lumberbot-appbot added the status: needs manual backport label

Jan 2, 2020

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request

Feb 16, 2020

Backport PRmatplotlib#16006: Ignore pos in StrCategoryFormatter.__ca…

80d0ac8

…ll__ to display correct label in the preview windowIgnore pos in StrCategoryFormatter.__call__ to display correct… (matplotlib#16006)Ignore pos in StrCategoryFormatter.__call__ to display correct label in the preview windowConflicts:lib/matplotlib/tests/test_category.py         - collision with py2 removal work (_to_str)

tacaswell removed the status: needs manual backport label

Feb 16, 2020

tacaswell mentioned this pull request

Feb 16, 2020

Backport PR #16006: Ignore pos in StrCategoryFormatter.__call__ to di…#16542

Merged

6 tasks

dstansby added a commit that referenced this pull request

Feb 17, 2020

Merge pull request#16542from tacaswell/auto-backport-of-pr-16006-on…

d15be69

…-v3.2.xBackport PR#16006: Ignore pos in StrCategoryFormatter.__call__ to di…

Labels

topic: categorical

4 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Ignore pos in StrCategoryFormatter.call to display correct label in the preview window#16006

Ignore pos in StrCategoryFormatter.call to display correct label in the preview window#16006

Uh oh!

Conversation

sujanasowrirajan commentedDec 22, 2019•
edited
Loading

Uh oh!

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

dstansbyDec 23, 2019

Choose a reason for hiding this comment

Uh oh!

sujanasowrirajanDec 24, 2019

Choose a reason for hiding this comment

Uh oh!

anntzer commentedJan 2, 2020•
edited
Loading

Uh oh!

Uh oh!

lumberbot-appbot commentedJan 2, 2020

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

Ignore pos in StrCategoryFormatter.__call__ to display correct label in the preview window#16006

Ignore pos in StrCategoryFormatter.__call__ to display correct label in the preview window#16006

Uh oh!

Conversation

sujanasowrirajan commentedDec 22, 2019• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

dstansbyDec 23, 2019

Choose a reason for hiding this comment

Uh oh!

sujanasowrirajanDec 24, 2019

Choose a reason for hiding this comment

Uh oh!

anntzer commentedJan 2, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

lumberbot-appbot commentedJan 2, 2020

Uh oh!

Uh oh!

Ignore pos in StrCategoryFormatter.call to display correct label in the preview window#16006

Ignore pos in StrCategoryFormatter.call to display correct label in the preview window#16006

sujanasowrirajan commentedDec 22, 2019•
edited
Loading

anntzer commentedJan 2, 2020•
edited
Loading