Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update backend_nbagg for removal of Gcf._activeQue.#15901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
anntzer merged 1 commit intomatplotlib:masterfromanntzer:nbactive
Dec 17, 2019

Conversation

anntzer
Copy link
Contributor

Looks like nbagg was (ab)using _activeQue to have "pyplot-managed
figures that can never be gcf()" (not really sure why? this was here
ever since nbagg was first merged in#3008). Now that _activeQue has been
merged into figs this is no longer possible, but Iguess the patch is
the closest in semantics?

Sorry I missed that in#13581. If that's too much of a problem we can revert#13581, but intentionally making Gcf.figs and Gcf._activeQue go out of sync is... a bit too clever?

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelDec 10, 2019
@anntzeranntzer added this to thev3.2.0 milestoneDec 10, 2019
@timhoffm
Copy link
Member

What is_activeQue after all? I do not find that anywhere else in the code. That would be sort of ok, because the PR removes all it's usages inbackend_nbagg.py. However the PR message and the comment in l.262ff seems to indicate that it's still a valid attribute. Am I missing something?

@anntzer
Copy link
ContributorAuthor

Before#13581 there was both Gcf.figs and Gcf._activeQue. figs was a mapping of manager numbers to manager instances, and _activeQue a list of managers such that the active manager was the one at the end. Ithought that they were always updated together and thus could just combine them together (making figs an OrderedDict), but I missed the fact that nbagg is the sole place which removes something from activeQue (making it nonactivable) without removing it from figs.

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Comment in line 262ff should be updated. There is no activeQue anymore.

Looks like nbagg was (ab)using _activeQue to have "pyplot-managedfigures that can never be gcf()" (not really sure why? this was hereever since nbagg was first merged in).  Now that _activeQue has beenmerged into figs this is no longer possible, but I *guess* the patch isthe closest in semantics?
@anntzer
Copy link
ContributorAuthor

done

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Anybody can merge after CI pass.

@anntzeranntzer merged commitbf584bd intomatplotlib:masterDec 17, 2019
@anntzeranntzer deleted the nbactive branchDecember 17, 2019 09:36
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 17, 2019
timhoffm added a commit that referenced this pull requestDec 17, 2019
…901-on-v3.2.xBackport PR#15901 on branch v3.2.x (Update backend_nbagg for removal of Gcf._activeQue.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@timhoffm@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp