NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Remove API deprecated in 3.1 (part 2)#15890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

timhoffm wants to merge1 commit intomatplotlib:masterfromtimhoffm:remove-3.1-deprecations2

Closed

Remove API deprecated in 3.1 (part 2)#15890

timhoffm wants to merge1 commit intomatplotlib:masterfromtimhoffm:remove-3.1-deprecations2

Conversation

Copy link

Member

timhoffm commentedDec 9, 2019

PR Summary

Follow up and goes on top of to#15878. The are so many changes that I didn't want to put everything in one PR. Even in two parts, each part is quite long.

You may wait until#15878 is merged or just review the second commit in this PR.

timhoffm changed the title~~emove API deprecated in 3.1 (part 2)~~Remove API deprecated in 3.1 (part 2)

Dec 9, 2019

timhoffm added status: waiting for other PR status: work in progress labels

Dec 9, 2019

Copy link

MemberAuthor

timhoffm commentedDec 9, 2019

For simplicity, will only fix the merge conflict after#15878 is in.

anntzer reviewed

Dec 9, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 9, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 9, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 9, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

timhoffm force-pushed theremove-3.1-deprecations2 branch from99635c3 tof8bc395Compare

December 10, 2019 00:00

anntzer added the status: needs rebase label

Dec 13, 2019

timhoffm force-pushed theremove-3.1-deprecations2 branch fromf8bc395 to3ca63dfCompare

December 15, 2019 22:40

timhoffm removed status: needs rebase status: waiting for other PR status: work in progress labels

Dec 15, 2019

timhoffm added this to thev3.3.0 milestone

Dec 15, 2019

timhoffm added API: changes Maintenance labels

Dec 15, 2019

timhoffm force-pushed theremove-3.1-deprecations2 branch 2 times, most recently from3c2ae89 to0126cc1Compare

December 16, 2019 00:41

Copy link

Contributor

anntzer commentedDec 16, 2019

breakage is real

timhoffm added the status: work in progress label

Dec 16, 2019

Copy link

MemberAuthor

timhoffm commentedDec 16, 2019

The failure is due to incomplete removal ofTextWithDash. Since removing that is a bit more involved, I've pulled this out to a separate PR#15950. Will come back here once that is merged.

timhoffm force-pushed theremove-3.1-deprecations2 branch from0126cc1 to2b8eb2dCompare

December 16, 2019 22:31

timhoffm removed the status: work in progress label

Dec 16, 2019

anntzer reviewed

Dec 16, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 16, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 16, 2019

View reviewed changes

lib/matplotlib/tests/test_scale.py OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 16, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 16, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

anntzer reviewed

Dec 16, 2019

View reviewed changes

doc/api/next_api_changes/removals.rst OutdatedShow resolvedHide resolved

timhoffm force-pushed theremove-3.1-deprecations2 branch from2b8eb2d to16c95a4Compare

December 16, 2019 23:38

Copy link

Contributor

anntzer commentedDec 17, 2019

Failures are real (bunch of mlab tests have to be deleted, in particular).

timhoffm force-pushed theremove-3.1-deprecations2 branch 3 times, most recently from6deea2a to380962aCompare

December 20, 2019 13:57

timhoffm added the status: work in progress label

Dec 20, 2019

Copy link

MemberAuthor

timhoffm commentedDec 20, 2019

Still some math-text related image comparison failures.

Copy link

Contributor

anntzer commentedDec 20, 2019

IIRC I had looked into this some time ago and the deprecation of stackrel may be the problematic one? in which case we can defer the removal of that part for now...