NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Optimize colors.to_rgba.#15834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

NelleV merged 1 commit intomatplotlib:masterfromanntzer:to_rgba

Dec 5, 2019

Merged

Optimize colors.to_rgba.#15834

NelleV merged 1 commit intomatplotlib:masterfromanntzer:to_rgba

Dec 5, 2019

Conversation

Copy link

Contributor

anntzer commentedDec 4, 2019

In the case where a (r, g, b) / (r, g, b, a) tuple is passed in this
PR makes _to_rgba_no_colorcycle ~2x faster (by avoiding converting to
ndarray and back to tuple). String inputs are handled earlier and thus
unchanged; array inputs are essentially as fast.

Lifted out of#15833 as it's also useful in itself.

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Optimize colors.to_rgba.

1cbf8ff

In the case where a (r, g, b) / (r, g, b, a) tuple is passed in thisPR makes _to_rgba_no_colorcycle ~2x faster (by avoiding converting tondarray and back to tuple).  String inputs are handled earlier and thusunchanged; array inputs are essentially as fast.

anntzer added the Performance label

Dec 4, 2019

anntzer mentioned this pull request

Dec 4, 2019

Fix build with numpy master.#15833

Closed

6 tasks