NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Fix build with numpy master.#15833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:numpy-master

Closed

Fix build with numpy master.#15833

anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:numpy-master

Conversation

Copy link

Contributor

anntzer commentedDec 4, 2019•
edited
Loading

Specifically, fix places where we build object arrays implicitly, as
that's deprecated on numpy master.

The change to colors.py may possibly(?) make conversion to rgba actually
slightlyfaster as we avoid the conversion to array in some cases.
(Edit: indeed, it's 2x faster in the relevant case, lifted this to its own PR:#15834.)

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Fix build with numpy master.

a63787a

Specifically, fix places where we build object arrays implicitly, asthat's deprecated on numpy master.The change to colors.py may possibly(?) make conversion to rgba actuallyslightly *faster* as we avoid the conversion to array in some cases.

anntzer force-pushed thenumpy-master branch from82252d9 toa63787aCompare

December 4, 2019 16:16