Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Tried to solve Issue #15650: Print URL when webbrowser.open Fails#15701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 2 commits intomatplotlib:masterfrommanan2501:issue-15650
Nov 17, 2019
Merged

Tried to solve Issue #15650: Print URL when webbrowser.open Fails#15701

dstansby merged 2 commits intomatplotlib:masterfrommanan2501:issue-15650
Nov 17, 2019

Conversation

@manan2501
Copy link
Contributor

@manan2501manan2501 commentedNov 16, 2019•
edited by timhoffm
Loading

PR Summary

Currently, the URL is shown only when rcParams['webagg.open_in_browser'] is False.
I have made changes so that the URL will be printed when webbrowser.open fails.

Closes#15650.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In the future, please try to give commits more descriptive messages, so that one does not need to try to figure out what#15650 means.

Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@manan2501
Copy link
ContributorAuthor

In the future, please try to give commits more descriptive messages, so that one does not need to try to figure out what#15650 means.

Pardon me for that(This was my first PR to such a huge project)

@manan2501manan2501 changed the titleTried to solve Issue #15650Tried to solve Issue #15650: Print URL when webbrowser.open FailsNov 16, 2019
@QuLogic
Copy link
Member

I'm having a hard time finding the return value forwebbrowser.open,@anntzer. Is this some undocumented result?

@anntzer
Copy link
Contributor

It's not documented AFAICT, you can just infer it from the source code (https://github.com/python/cpython/blob/3.8/Lib/webbrowser.py#L71).

timhoffm reacted with thumbs up emoji

@dstansbydstansby added this to thev3.3.0 milestoneNov 17, 2019
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! 🎉

@dstansbydstansby merged commit690fd71 intomatplotlib:masterNov 17, 2019
@manan2501manan2501 deleted the issue-15650 branchNovember 17, 2019 23:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

@QuLogicQuLogicAwaiting requested review from QuLogic

Assignees

No one assigned

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

URL is not shown when webagg failed to open the browser.

5 participants

@manan2501@QuLogic@anntzer@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp