Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Avoid a RuntimeError at animation shutdown with PySide2.#15685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:masterfromanntzer:isdeleted
Mar 14, 2020

Conversation

anntzer
Copy link
Contributor

PR Summary

Fixes the "Internal C++ object already deleted" part of#15678 (comment) (@dopplershift, perhaps this also fixes the rest if you're lucky?).
Seemottosso/Qt.py#316 for how to translate the isdeleted API with PySide. See#9993 (comment) re the "double import" of sip with PyQt4.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Copy link
ContributorAuthor

fwiw I can also repro the issue now, and its resolution by this PR, using PyQt5 -- run animation/strip_chart.py, wait for the strip chart to go at least once through the axes, and quit.

@timhoffm
Copy link
Member

@anntzer Do I understand your correctly: The bug should happen when runninganimation/strip_chart.py with Qt5Agg backend on master?

That quits cleanly here. (Not tested with PySide2 as I've not installed that.)

@anntzer
Copy link
ContributorAuthor

Yes, it fails locally with me at exit with qt5agg/master. Did you wait for the strip chart to go at least once through the whole axes?

@timhoffm
Copy link
Member

Yes I did.

@QuLogicQuLogic mentioned this pull requestMar 9, 2020
@tacaswelltacaswell merged commit062cd15 intomatplotlib:masterMar 14, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 14, 2020
QuLogic added a commit that referenced this pull requestMar 14, 2020
…685-on-v3.2.xBackport PR#15685 on branch v3.2.x (Avoid a RuntimeError at animation shutdown with PySide2.)
@anntzeranntzer deleted the isdeleted branchMarch 14, 2020 11:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dopplershiftdopplershiftdopplershift approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@timhoffm@dopplershift@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp