Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Dev docs update#15617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 6 commits intomatplotlib:masterfrompambot:macosx-dev-docs-update
Jul 3, 2020
Merged

Conversation

pambot
Copy link
Contributor

PR Summary

Thiscloses#15610, which is about some missing information in the development installation docs.

  • link to devdocs, the main page can be confused for the latest master docs
  • git clean -xfd if you want to change configs and rebuild
  • pip install -e . for dev
  • make a dev.txt that is union of travis all flake8 36 (doc it too)
  • maybe update main readme

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@pambotpambotforce-pushed themacosx-dev-docs-update branch from32c9a41 to262d6d4CompareNovember 6, 2019 20:17
@pambotpambotforce-pushed themacosx-dev-docs-update branch 2 times, most recently frome8d6f55 to91fcbefCompareNovember 6, 2019 21:14
@pambot
Copy link
ContributorAuthor

pambot commentedNov 6, 2019•
edited
Loading

@tacaswell Thanks for the comments! I addressed them all.

@pambot
Copy link
ContributorAuthor

@tacaswell Could you please take another look? I'm up for more edits if it needs it.

@tacaswell
Copy link
Member

@pambot Hope you don't mind I took the liberty of resolving some of the discussions by pushing commits!

doc/index.rst Outdated
@@ -53,6 +53,7 @@ This is the documentation for Matplotlib version |version|.

To get started, read the :doc:`User's Guide <users/index>`.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

remove the change here?

@tacaswelltacaswell added this to the3.2-doc milestoneMar 15, 2020
@tacaswelltacaswellforce-pushed themacosx-dev-docs-update branch froma7a734d to9cdcad2CompareJuly 1, 2020 03:06
@tacaswelltacaswell modified the milestones:3.2-doc,v3.4.0Jul 1, 2020
This makes sure they won't get out of sync
@tacaswelltacaswell requested a review fromtimhoffmJuly 1, 2020 03:12
@tacaswelltacaswell requested a review fromstory645July 1, 2020 03:13
Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would prefer all the simple/easy/etc stripped out but as this is so overdue that can go into a follow up PR.

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some restructuredText formatting issues.

Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@tacaswell
Copy link
Member

Will merge if the docs come back green.

@tacaswelltacaswell merged commit3f4d4c7 intomatplotlib:masterJul 3, 2020
@tacaswell
Copy link
Member

Thanks@pambot ! Sorry this got lost in the shuffle for so long.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer left review comments

@jklymakjklymakjklymak left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@tacaswelltacaswelltacaswell approved these changes

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Link to most recent DevDocs when installing from Master Source
7 participants
@pambot@tacaswell@story645@anntzer@jklymak@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp