Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use svg instead of png for website logo#15533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromtimhoffm:svg-logo
Oct 27, 2019

Conversation

timhoffm
Copy link
Member

PR Summary

This reverts an accidental flip svg -> png introduced in#10065. Sorry for the error!

@tacaswell
Copy link
Member

tacaswell commentedOct 26, 2019
edited
Loading

We should look into trying to shirk the svg before we make this change. The png in 20k, the svg is 128k. The whole site is currently ~300k and we are worrying about 160k per font in#15516 .

timhoffm reacted with thumbs up emoji

@tacaswelltacaswell modified the milestones:v3.2.0,v3.1-docOct 26, 2019
@timhoffm
Copy link
MemberAuthor

I've compressed the svg from 128k to 11k usinghttps://vecta.io/nano (precision level 2). That includes a slightly lossy compression (nodes are slightly moved), but you won't notice unless really flipping back and forth on larger magnifications.

@jklymakjklymak merged commit2184402 intomatplotlib:masterOct 27, 2019
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2184402cf7fcccb25c24566c190655319f22837a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15533: Use svg instead of png for website logo'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-15533-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR#15533 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.1-doc$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2184402cf7fcccb25c24566c190655319f22837a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15533: Use svg instead of png for website logo'
  1. Push to a named branch :
git push YOURFORK v3.1.1-doc:auto-backport-of-pr-15533-on-v3.1.1-doc
  1. Create a PR against branch v3.1.1-doc, I would have named this PR:

"Backport PR#15533 on branch v3.1.1-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@tacaswell
Copy link
Member

I spoke with@dorafc about this. Her only concern was if all browsers would support this. According tohttps://caniuse.com/#feat=svg everything but dangerously out of date IE does. There is a handful (~130 / 276,000 in the last week) of users who would be hit by this but it is probably but it is not enough to worry about.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 27, 2019
tacaswell added a commit that referenced this pull requestOct 27, 2019
…533-on-v3.2.xBackport PR#15533 on branch v3.2.x (Use svg instead of png for website logo)
@tacaswell
Copy link
Member

I'm working on backporting this to the 3.1 series.

@timhoffmtimhoffm deleted the svg-logo branchOctober 28, 2019 00:57
tacaswell pushed a commit that referenced this pull requestOct 28, 2019
Use svg instead of png for website logoConflicts:doc/_templates/layout.html          - git is having trouble patching html
@tacaswell
Copy link
Member

Backported directly to v3.1.1-doc as7830e26 and will get onto v3.1.x by merging v3.1.1-doc into v3.1.x before tagging v3.2.0.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1-doc
Development

Successfully merging this pull request may close these issues.

3 participants
@timhoffm@tacaswell@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp