Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Autoscale for ax.arrow()#15392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromchoyiny:arrow-autoscale
Mar 25, 2020
Merged

Conversation

choyiny
Copy link
Contributor

@choyinychoyiny commentedOct 8, 2019
edited
Loading

PR Summary

When ax.arrow() is called, a FancyArrow object is being added to the current axes as an artist and not a patch. So when autoscale_view is called, which loops through all Patches and scales the view based on the minimum and maximum of those, the FancyArrow isn't being considered.
The solution is a two-step process. First, we have to add the arrow as a Patch, and second, we have to lazily call autoscale_view() after adding it on the axes.

Part of a course at University of Toronto with@atafliovich.

Resolves#12712
Takes over#13788

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

teto reacted with thumbs up emojiteto and liujordan reacted with hooray emoji
@choyinychoyiny mentioned this pull requestOct 8, 2019
6 tasks
@choyinychoyinyforce-pushed thearrow-autoscale branch 2 times, most recently from90794e4 to735996fCompareOctober 10, 2019 17:13
@choyiny
Copy link
ContributorAuthor

Some weird error about test timeout in latest travis build. Force pushing to restart tests.

Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks right to me

@choyiny
Copy link
ContributorAuthor

Not sure what is happening with the tests, but they don't seem to relate to my change.

@timhoffm
Copy link
Member

Sorry for the inconvenience. There was an incorrect merge causing CI to fail (#16897). Can you please rebase on top of master?

@QuLogic
Copy link
Member

No need, a close/open should do.

@QuLogicQuLogic reopened thisMar 24, 2020
@QuLogicQuLogic merged commitdefce2e intomatplotlib:masterMar 25, 2020
@QuLogicQuLogic added this to thev3.3.0 milestoneMar 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer left review comments

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Autoscale does not work for ax.arrow()
5 participants
@choyiny@timhoffm@QuLogic@anntzer@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp