Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Autoscale for ax.arrow()#15392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Autoscale for ax.arrow()#15392
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
90794e4
to735996f
CompareSome weird error about test timeout in latest travis build. Force pushing to restart tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks right to me
Not sure what is happening with the tests, but they don't seem to relate to my change. |
Sorry for the inconvenience. There was an incorrect merge causing CI to fail (#16897). Can you please rebase on top of master? |
No need, a close/open should do. |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
When ax.arrow() is called, a FancyArrow object is being added to the current axes as an artist and not a patch. So when autoscale_view is called, which loops through all Patches and scales the view based on the minimum and maximum of those, the FancyArrow isn't being considered.
The solution is a two-step process. First, we have to add the arrow as a Patch, and second, we have to lazily call autoscale_view() after adding it on the axes.
Part of a course at University of Toronto with@atafliovich.
Resolves#12712
Takes over#13788
PR Checklist