Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix tooltip display bug#15387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 2 commits intomatplotlib:masterfromdorafc:fix_tooltip_display_bug
Mar 29, 2020

Conversation

dorafc
Copy link
Contributor

Updated CSS to fix an issue with the tooltip being cutoff by the
edge of the content. This change is dependent on updates to sphinx
gallery. This will also require a sphinx gallery version bump after the new version is released (otherwise there will be block of extra white space on the page)

requiressphinx-gallery/sphinx-gallery#543

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm reacted with thumbs up emoji
@timhoffm
Copy link
Member

sphinx-gallery/sphinx-gallery#543 has been included in sphinx-gallery 0.5. IMHO we should bump our dependency and move this forward.

@tacaswelltacaswell added this to the3.2-doc milestoneMar 28, 2020
Updated CSS to fix an issue with the tooltip being cutoff by theedge of the content. This change is dependent on updates to sphinxgallery.
This is the lowest version that has the CSS bug fix
@dorafcdorafcforce-pushed thefix_tooltip_display_bug branch froma079333 toef82f81CompareMarch 28, 2020 19:40
@tacaswelltacaswell merged commit160f8ad intomatplotlib:masterMar 29, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.1-doc$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 160f8ad054eb674206aa60cf3a95b0803da4f576
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15387: fix tooltip display bug'
  1. Push to a named branch :
git push YOURFORK v3.2.1-doc:auto-backport-of-pr-15387-on-v3.2.1-doc
  1. Create a PR against branch v3.2.1-doc, I would have named this PR:

"Backport PR#15387 on branch v3.2.1-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestMar 30, 2020
Merge pull requestmatplotlib#15387 from dorafc/fix_tooltip_display_bugDOC: fix tooltip display bug
QuLogic added a commit that referenced this pull requestMar 30, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2-doc
Development

Successfully merging this pull request may close these issues.

3 participants
@dorafc@timhoffm@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp