Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Document formatting strings in the docs#15379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromtimhoffm:string-quotes
Oct 7, 2019

Conversation

timhoffm
Copy link
Member

@timhoffmtimhoffm commentedOct 4, 2019
edited
Loading

PR Summary

Clarification motivated by#15375 (comment).

Based on#10225 (sectionString values).

Plus a minor wording fix in one of the examples.

@timhoffmtimhoffm added this to thev3.1-doc milestoneOct 4, 2019
@timhoffmtimhoffmforce-pushed thestring-quotes branch 2 times, most recently from79c1c56 to476a03eCompareOctober 4, 2019 16:43
@@ -410,6 +410,12 @@ Use simple single or double quotes when giving string values, e.g.

If 'tight', try to figure out the tight bbox of the figure.

No ``'extra'`` literal quotes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Was this meant to be a title instead of part of the code block?

Copy link
MemberAuthor

@timhoffmtimhoffmOct 6, 2019
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, this is intentional. Originally, I tried to put this in an inline lieteral:

The use of extra literal quotes around the text (````'extra'````) is discouraged.

However, it appears that four backticks followed by a single-quote or double-quote character are not interpreted correctly by Sphinx/ReST (in contrast followed by a letter works, e.g.````literal```` further above).

I would like to have the negative example shown somewhere, but did not manage to write it as an inline literal. So I just added it it to the block literal.

dstansby reacted with thumbs up emoji
@tacaswelltacaswell modified the milestones:v3.1-doc,v3.2.0Oct 7, 2019
@tacaswell
Copy link
Member

Although this is a doc change, I don't think we need to pull it back to the 3.1 branches.

@dstansbydstansby merged commit74ed294 intomatplotlib:masterOct 7, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestOct 7, 2019
dstansby added a commit that referenced this pull requestOct 7, 2019
…379-on-v3.2.xBackport PR#15379 on branch v3.2.x (Document formatting strings in the docs)
@timhoffmtimhoffm deleted the string-quotes branchOctober 7, 2019 18:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dstansbydstansbydstansby left review comments

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

3 participants
@timhoffm@tacaswell@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp