Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix broken imports.#15356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Fix broken imports.#15356
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Fix broken imports.- Workaround Arc bug.
anntzer commentedOct 1, 2019
| @@ -1667,7 +1667,7 @@ def segment_circle_intersect(x0, y0, x1, y1): | |||
| # circle in the same way that it is relative to the desired ellipse. | |||
| box_path = Path.unit_rectangle() | |||
| box_path_transform = (transforms.BboxTransformTo(self.axes.bbox) | |||
| - self.get_transform()) | |||
| + self.get_transform().inverted()) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is less precise (box_path gets some ~1e-19 errors) but is needed to make Arc work...
jklymak approved these changesOct 1, 2019
Does this need to be back ported to 3.2? Or can we milestone it 3.3? |
tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestJun 17, 2020
Merge pull requestmatplotlib#17564 from tacaswell/fix_big_arcFIX: big arc code path Conflicts:lib/matplotlib/patches.py - implicitly backport a change frommatplotlib#15356 (from `- trans ` -> `+ trans.inverted()`)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
... due to#15210 crossing wires with other PRs.
Also needed to revert part of#14845 (cleanup) which exposed some of the issues hinted at in#14694.
will self-merge on CI pass.
PR Checklist